PHPUnit

Quality Assurance on PHP projects – PHPUnit lessons learned

This is what I like about the PHP community: people work out similar ideas and share what they’ve learned in the process. Sometimes people pick up ideas and work them out, sometimes people just continue the conversation.

And I believe Lars Tesmer has done the latter, where he blogs on testing PHPUnit itself and the lessons learned in that process.

Thank you Lars for sharing your lessons.



Author:

by News Robot on September 16, 2011 in News, No Comments »
tags: , , , , ,

Quality Assurance on PHP projects – PHPUnit part 4

     In parts one, two and three we focussed on writing tests for a game of tic-tac-toe, with in parts two and three we optimized our tests so they focus on the functionality of the individual parts Grid and Player, with a collection class Players to handle Player objects.

In this fourth part we should focus on playing the game. Let’s go over the steps again:

  • each player chooses a symbol
  • for each turn (max 9 turns)
    • a player places his symbol on the grid
    • if 3 symbols appear in a single row (horizontal, vertical or diagonal)
      • player is a winner

So this is a simple and a straightforward rule we can turn into code. But let’s look at the tests we’ve written in part 1 to see if they’re still valid.

    public function testGameCanBePlayed()    {        $playerX = $this->_ttt->getPlayers()->seek(0)->current();        $playerO = $this->_ttt->getPlayers()->seek(1)->current();

        $this->assertFalse($this->_ttt->play(0, 0, $playerX));        $this->assertFalse($this->_ttt->play(0, 1, $playerX));        $this->assertTrue($this->_ttt->play(0, 2, $playerX));

        $this->_ttt->setGrid(new Grid());

        $this->assertFalse($this->_ttt->play(0, 0, $playerX));        $this->assertFalse($this->_ttt->play(1, 0, $playerX));        $this->assertTrue($this->_ttt->play(2, 0, $playerX));

        $this->_ttt->setGrid(new Grid());

        $this->assertFalse($this->_ttt->play(0, 0, $playerX));        $this->assertFalse($this->_ttt->play(1, 1, $playerX));        $this->assertTrue($this->_ttt->play(2, 2, $playerX));

        $this->_ttt->setGrid(new Grid());

        $this->assertFalse($this->_ttt->play(0, 2, $playerX));        $this->assertFalse($this->_ttt->play(1, 1, $playerX));        $this->assertTrue($this->_ttt->play(2, 0, $playerX));    }

As you see, we only tested the functionality to see if we can have a winner when 3 identical symbols appear in a single row horizontal, vertical or diagonal. We can make a couple of comments on this test:

  • this test is named wrong as it doesn’t test the gameplay functionality
  • this test should be branched out into different tests for each row
  • this test doesn’t test turn-by-turn game play

In other words, we need to clean this up and come up with better tests! Let’s focus on tearing this test into 3 separate tests, testing just a single direction. Again, we can use a dataProvider method for this.

    public function rowColProvider()    {        return array (            array (array (array (0,0), array (0,1), array (0,2))),            array (array (array (0,0), array (1,0), array (2,0))),            array (array (array (0,0), array (1,1), array (2,2))),            array (array (array (0,2), array (1,1), array (2,0))),        );    }    /**     * @dataProvider rowColProvider     */    public function testGameplayCanDetectWinner($rowCols)    {        $player = $this->_ttt->getPlayers()->seek(0)->current();        $this->assertFalse($this->_ttt->play($rowCols[0][0], $rowCols[0][1], $player));        $this->assertFalse($this->_ttt->play($rowCols[1][0], $rowCols[1][1], $player));        $this->assertTrue($this->_ttt->play($rowCols[2][0], $rowCols[2][1], $player));    }

Now we know that with each turn, the return value will indicate if we have a winner (TRUE) or not (FALSE). But we still need to see if we can have the same result when playing with two players. As you see with the last line, the third entry gives us a positive result.

But we still don’t have a gameplay going! We need to have two players enter the arena and each player playing turn by turn. So how do we approach this? Well, the easiest way for now is to create a test that does just that. The benefit here is we can decide which player is going to win the game.

    public function testGameCanBePlayed()    {        $playerX = $this->_ttt->getPlayers()->seek(0)->current();        $playerO = $this->_ttt->getPlayers()->seek(1)->current();        $this->assertFalse($this->_ttt->play(0, 0, $playerX));        $this->assertFalse($this->_ttt->play(0, 1, $playerO));        $this->assertFalse($this->_ttt->play(1, 1, $playerX));        $this->assertFalse($this->_ttt->play(2, 2, $playerO));        $this->assertFalse($this->_ttt->play(1, 0, $playerX));        $this->assertFalse($this->_ttt->play(2, 0, $playerO));        $this->assertTrue($this->_ttt->play(1, 2, $playerX));    }

Visual this result looks like the following grid:

 X | O |    X | X | X  O |   | O 

But most importantly our tests are still green, giving us that wonderful feeling of achievement.

Let’s finish up our tests so we can see no one can play any further after we’ve got a winner. PHPUnit provides a nice anotation we can use for this: depends. So now we can test that the game is stopped, depending on our test “testGameCanBePlayed”.
For this to work, we need to return our game (in this case $this->_ttt). Just add the following line at the bottom of the test class “testGameCanBePlayed”.

    public function testGameCanBePlayed()    {        $playerX = $this->_ttt->getPlayers()->seek(0)->current();        $playerO = $this->_ttt->getPlayers()->seek(1)->current();        $this->assertFalse($this->_ttt->play(0, 0, $playerX));        $this->assertFalse($this->_ttt->play(0, 1, $playerO));        $this->assertFalse($this->_ttt->play(1, 1, $playerX));        $this->assertFalse($this->_ttt->play(2, 2, $playerO));        $this->assertFalse($this->_ttt->play(1, 0, $playerX));        $this->assertFalse($this->_ttt->play(2, 0, $playerO));        $this->assertTrue($this->_ttt->play(1, 2, $playerX));        return $this->_ttt;    }

And the next step is simple:

    /**     * @depends testGameCanBePlayed     * @expectedException RuntimeException     */    public function testGameStopsAfterWinning($game)    {        $playerO = $game->getPlayers()->seek(1)->current();        $game->play(2,1, $playerO);    }

In order for this test to succeed we need to add a couple of things to our game:

  • a status property that will tell us if there’s a winner
  • a setter method to flip the flag once a winner is detected
  • a checking method to verify a winner is not yet detected
  • modify our play method so it throws a RuntimeException when we try to play when a winner exists.
<?php...

class Tictactoe{    ...

    /**     * Status indicator to say there's a winner or not     *      * @var bool     */    protected $_winner = false;

    ...

    /**     * Sets a flag to indicate this game has a winner     *      * @param bool $flag     * @return Tictactoe     */    public function setWinner($flag = true)    {        $this->_winner = $flag;        return $this;    }    /**     * Checks if the game has a winner     *      * @return bool     */    public function hasWinner()    {        return $this->_winner;    }    /**     * Plays the game and returns TRUE if a player has become a winner, FALSE     * if the player is not (yet) a winner.     *      * @param int $row     * @param int $column     * @param Player $player     * @return bool     * @throws RuntimeException     */    public function play($row, $column, Player $player)    {        if ($this->hasWinner()) {            throw new RuntimeException('Game already has a winner');        }        $this->getGrid()->setSymbol($row, $column, $player->getSymbol());        return $this->isWinner($player);    }    /**     * Returns TRUE if a player has become a winner, FALSE if not.     *      * @param Player $player     * @return bool     */    public function isWinner(Player $player)    {        if ($this->getGrid()->inRow($player->getSymbol())) {            $this->setWinner();            return true;        }        if ($this->getGrid()->inColumn($player->getSymbol())) {            $this->setWinner();            return true;        }        if ($this->getGrid()->inDiagonal($player->getSymbol())) {            $this->setWinner();            return true;        }        return false;    }}

That’s it. We covered the main purpose of the game and we did it semi test driven. We can start playing a cute little game of Tictactoe and covered a couple important features of PHPUnit. I also showed that it’s not a bad thing if you modify parts of your tests to achieve new or other specifications.

The full game source code can be found on my github account (https://github.com/DragonBe/tictactoe), and as you go over the log, you can follow along with these series as well. When playing with the source code, you might think about testing edge cases: playing 9 rounds and no winner, try to place a symbol off the grid, place twice a symbol on the grid of a single player (cheating), and so on.

Another thing could be that you turn this little game into an online game. What are the things you need to concider in that situation. Are our tests still valid or do we need to modify our architecture and our tests to support that kind of game playing?

Since it’s on GitHub, you can fork it and send me a pull request once you have an edge case figured out.



Author:

by News Robot on September 4, 2011 in News, No Comments »
tags: , , , ,

Quality Assurance on PHP projects – PHPUnit part 3

Time for the third part on unit testing with phpunit in my Quality Assurance on PHP projects series. In part one we started writing unit tests for a simple game of tic-tac-toe. In part two we started converting our unit tests into actual code and moved our general unit test code for grids into a Grid focussed unit test. In this part, we’re looking at how we can optimize the tests for our players.

When we look at our initial tests for players, we only focussed on two things: each player has a symbol and players are managed within a collection class.

    public function testGamePlayersAreSetAtStart()    {        $players = $this->_ttt->getPlayers();        $this->assertInstanceOf('Players', $players);        $this->assertEquals(2, count($players));        $this->assertEquals(Player::PLAYER_X, $players->seek(0)->current()->getSymbol());        $this->assertEquals(Player::PLAYER_O, $players->seek(1)->current()->getSymbol());    }

As you can imagine, this is a very minimalistic test that cannot cope with all player related issues. We did have two classes to handle all player related issues and thus we need to move our test out of our TictactoeTest class.

A quick look at the functionality of a player should give us more fuel to creat better unit tests. Bytaking a new look at the functionality of a single player, we can optimize our tests. Since we already have some working code, let’s take a quick look at the Player class to figure out what is being expected.

<?php/** * TicTacToe *  * A simple game that's played with two players, each taking a turn by marking * a field in a grid of 3 x 3 with either an X or an O (one symbol per player). * Winner is the one who has 3 identical symbols in a single horizontal, * vertical or diagonal row. *  * @package Tictactoe * @license "Attribution-ShareAlike 3.0 Unported (CC BY-SA 3.0)" * @link http://creativecommons.org/licenses/by-sa/3.0/ *//** * Player *  * This Player class is responsible to set up and maintain a single player *  * @package Tictactoe * @category Tictactoe * */class Player{    /**     * Defines the symbol X for a player to choose     *      * @var string     */    const PLAYER_X = 'X';    /**     * Defines the symbol X for a player to choose     *      * @var string     */    const PLAYER_O = 'O';    /**     * The symbol a player chooses     *      * @var string     */    protected $_symbol;    /**     * Constructor for a single player, with an optional symbol (X or O) to     * define the player's playing symbol     *      * @param string $symbol     */    public function __construct($symbol = null)    {        if (null !== $symbol) {            $this->setSymbol($symbol);        }    }    /**     * Sets a symbol for this Player     *      * @param string $symbol     * @return Player     */    public function setSymbol($symbol)    {        $this->_symbol = (string) $symbol;        return $this;    }    /**     * Retrieves the chosen symbol from this Player     *      * @return string     */    public function getSymbol()    {        return $this->_symbol;    }}

As you can see, we only care about the symbol of the player. Apparently this is more than enough for now. But when we check our main TictactoeTest we see no specific tests for our Player class. About time to do something about it.

<?phpclass PlayerTest extends PHPUnit_Framework_TestCase{    protected $_player;    protected function setUp()    {        $this->_player = new Player();        parent::setUp();    }    protected function tearDown()    {        $this->_player = null;        parent::tearDown();    }    public function testPlayerHasNoSymbolAtStartup()    {        $this->assertNull($this->_player->getSymbol());    }    public function goodSymbolProvider()    {        return array (            array ('O'),            array ('X'),        );    }    /**     * @dataProvider goodSymbolProvider     */    public function testPlayerCanSetASymbol($symbol)    {        $this->_player->setSymbol($symbol);        $this->assertEquals($symbol, $this->_player->getSymbol());    }}

In our code and in our tests we only set a symbol, but don’t check if the symbol is valid. The rules of this game do specify that only a X or a O are allowed. So we need to add additional logic to our tests and code. Let’s work on our test first.

    public function badSymbolProvider()    {        return array (            array ('a'),            array (123),            array ('Hello World!'),            array (0x123),        );    }    /**     * @dataProvider badSymbolProvider     * @expectedException InvalidArgumentException     */    public function testPlayerThrowsExceptionWithBadSymbol($symbol)    {        $this->_player->setSymbol($symbol);    }

By using the ‘expectedException‘ annotation we can verify that a specific exception is thrown. For most exceptions you can often use one of the SPL exceptions. We choose ‘InvalidArgumentException‘ as the symbol is an invalid argument for this Player class. Of course our tests will fail as we haven’t forseen this feature or behaviour.

InvalidArgumentException

We need to modify our code so it can be throw an InvalidArgumentException when wrong arguments (read symbols) are being provided. We want our tests to succeed, right?

    /**     * Sets a symbol for this Player     *      * @param string $symbol     * @return Player     * @throws InvalidArgumentException     */    public function setSymbol($symbol)    {        $validSymbols = array (self::PLAYER_O, self::PLAYER_X);        if (!in_array($symbol, $validSymbols)) {            throw new InvalidArgumentException(                'Player can only choose between X or O');        }        $this->_symbol = (string) $symbol;        return $this;    }

As you can see, it’s just a small but significant change that ensures proper symbols are being used in our game. And our tests now succeed.

InvalidArgumentException
So we can increase the quality of the game by making sure only allowed symbols are used.

We also have a collection class called Players that contain both players. We could have used an array, but as we don’t know yet what kind of functionality we want for all players. In our code we just created this collection that implements the SeekableIterator and Countable interfaces. Our PlayersTest should be able to add a Player object, even two Player objects but certainly not more than 2 players. In test code this becomes a simple straightforward test.

<?phpclass PlayersTest extends PHPUnit_Framework_TestCase{    protected $_players;

    protected function setUp()    {        $this->_players = new Players();        parent::setUp();    }    protected function tearDown()    {        parent::tearDown();        $this->_players = null;    }    public function testPlayersIsEmptyAtStartUp()    {        $this->assertEmpty($this->_players->getPlayers());    }    public function testPlayerCanAddPlayer()    {        $this->_players->addPlayer(new Player());        $this->assertEquals(1, count($this->_players));    }    public function testPlayerCanTwoPlayerObjects()    {        $this->_players->addPlayer(new Player())                       ->addPlayer(new Player());        $this->assertEquals(2, count($this->_players));    }    /**     * @expectedException OverflowException     */    public function testPlayerCannotAddMoreThenTwoPlayerObjects()    {        $this->_players->addPlayer(new Player())                       ->addPlayer(new Player())                       ->addPlayer(new Player());    }}

Since we implement 2 interfaces we know the functionality of them, and therefor we should not test for it as they will throw errors if not implemented correctly. If you still doubt yourself on working with these interfaces, create a separate set of tests that just verifies your collection class is behaving as expected. Our collection class Players will look like this.

<?php/** * TicTacToe *  * A simple game that's played with two players, each taking a turn by marking * a field in a grid of 3 x 3 with either an X or an O (one symbol per player). * Winner is the one who has 3 identical symbols in a single horizontal, * vertical or diagonal row. *  * @package Tictactoe * @license "Attribution-ShareAlike 3.0 Unported (CC BY-SA 3.0)" * @link http://creativecommons.org/licenses/by-sa/3.0/ *//** * Players *  * This Players class is a collection container for both players, implementing * both Countable and SeekableIterator interfaces from SPL *  * @package Tictactoe * @category Tictactoe * @see SeekableIterator * @see Countable * @link http://php.net/spl * */class Players implements SeekableIterator, Countable{    const MAX_PLAYERS = 2;    /**     * Contains Player objects     *      * @var array     */    protected $_players = array ();    /**     * Specifies the position in the stack     *      * @var int     */    protected $_position;    /**     * Keeps track of the count     *      * @var int     */    protected $_count;    /**     * Constructor for this Players collection, allows setting players with     * optional provided array of Player objects     *      * @param array $array     */    public function __construct(array $array = null)    {        if (null !== $array) {            foreach ($array as $player) {                $this->addPlayer($player);            }        }    }    /**     * Adds a Player object to the collection     *      * @param Player $player     * @return Players     * @throw Overflow     */    public function addPlayer(Player $player)    {        if (self::MAX_PLAYERS <= $this->count()) {            throw new OverflowException('Cannot add more Player objects');        }        $this->_players[] = $player;        return $this;    }    /**     * Retrieves a list of Player objects currently in the collection     *      * @return array     */    public function getPlayers()    {        return $this->_players;    }    /**     * Sets the internal stack pointer back to 0     *      * @see SeekableIterator::rewind()     */    public function rewind()    {        $this->_position = 0;    }    /**     * Sets the internal stack pointer to the next position     *      * @see SeekableIterator::next()     */    public function next()    {        $this->_position++;    }    /**     * Checks if the current position in the stack is still valid     *      * @see SeekableIterator::valid()     * @return boolean     */    public function valid()    {        return isset ($this->_player[$this->_position]);    }    /**     * Retrieves the current object from the stack     *      * @see SeekableIterator::current()     * @return Player     */    public function current()    {        return $this->_players[$this->_position];    }    /**     * Retrieves the current position from the stack     *      * @see SeekableIterator::key()     * @return int     */    public function key()    {        return $this->_position;    }    /**     * Moves the position to the given stack postion     *      * @see SeekableIterator::seek()     * @throws OutOfBoundsException     */    public function seek($position)    {        if (!isset ($this->_players[$position])) {            throw new OutOfBoundsException('No more items in this stack');        }        $this->_position = $position;        return $this;    }    /**     * Keeps record of the count in this collection     *      * @see Countable::count()     */    public function count()    {        return count($this->_players);    }}

Ok, we now have our Grid and our Player objects tested. Next up is testing the game itself. Are all our tests taking care of all rules defined by the game? What are the edge cases? What is not acceptable? All this and more in the next eppisode of ‘Quality Assurance on PHP projects‘.



Author:

by News Robot on August 28, 2011 in News, No Comments »
tags: , , , ,

Quality Assurance on PHP projects – PHPUnit part 2

     I hope everyone enjoyed my first article on unit testing with phpunit where I started writing a few tests that would guide us building our little game of tictactoe. Today I’m going start with turning these tests into working code and adjusting our tests to have a clear separation of responsibility. Since we already know what the code should produce, we only have to work out the details.

Our tests tell us we have four classes:

  • Tictactoe: the main class that is responsible for the game and how it should be played
  • Grid: is the class that’s responsible for setting up the playing grid
  • Players: a collection class containing both player objects
  • Player: the class defining a single player

Our first test concerns all about the grid we’re going to use. Here’s the test again:

    public function testGameGridIsSetAtStart()    {        $grid = $this->_ttt->getGrid();        $this->assertInstanceOf('Grid', $grid);        $this->assertEquals(3, count($grid->getRows()));        foreach ($grid->getRows() as $row) {            $this->assertInternalType('array', $row);            $this->assertEquals(3, count($row));            $this->assertNull($row[0]);            $this->assertNull($row[1]);            $this->assertNull($row[2]);        }    }   

What can we learn from this test?

  • Grid is part of our main TicTacToe class
  • has a method that fetches rows of type array
    • and each row has columns as an array

We can also make the following assumptions:

  • Grid class will instantiate a grid with 3 rows and 3 columns
  • When calling “getRows()” we retrieve an array of 3 columns
  • Each field in the grid will have a null value as a default
  • A Player must have a way to set his “symbol” on a specific position on the grid
  • Must have a way to verify if a given symbol exists in either a horizontal, a vertical or a diagonal row

With this information we can start writing our Grid class

<?php/** * TicTacToe *  * A simple game that's played with two players, each taking a turn by marking * a field in a grid of 3 x 3 with either an X or an O (one symbol per player). * Winner is the one who has 3 identical symbols in a single horizontal, * vertical or diagonal row. *  * @package Tictactoe * @license "Attribution-ShareAlike 3.0 Unported (CC BY-SA 3.0)" * @link http://creativecommons.org/licenses/by-sa/3.0/ *//** * Grid *  * This Grid class is responsible to set up and maintain the playing field *  * @package Tictactoe * @category Tictactoe * */class Grid{    /**     * Constant to define the number of rows     * @var int     */    const ROWS = 3;    /**     * Constant to define the number of colomns     * @var int     */    const COLS = 3;    /**     * Container for all rows and columns     *      * @var array     */    protected $_rows = array ();    /**     * Constructor for this Grid class that will set up our grid with 3 rows     * and 3 columns while setting the value of each field to NULL     */    public function __construct()    {        for ($i = 0; $i < self::ROWS; $i++) {            $columns = array ();            for ($j = 0; $j < self::COLS; $j++) {                $columns[$j] = null;            }            $this->addRow($columns);        }    }    /**     * Adds a row to the grid, requiring an array of 3 fields representing     * the columns     *      * @param array $row     * @return Grid     */    public function addRow(array $row)    {        $this->_rows[] = $row;        return $this;    }    /**     * Retrieves all rows from this grid, including an array for the columns     * for each row     *      * @return array     */    public function getRows()    {        return $this->_rows;    }    /**     * Sets the symbol for each field     *      * @param int $row The position of the field in the row     * @param int $column The position of the field in the column     * @param string $symbol     */    public function setSymbol($row, $column, $symbol)    {        $this->_rows[$row][$column] = $symbol;        return $this;    }    /**     * Retrieves the current symbol from a given cordinate on the grid     *      * @param int $row The postion of the field in the row     * @param int $column The position of the field in the column     * @return string     */    public function getSymbol($row, $column)    {        return $this->_rows[$row][$column];    }    /**     * Validation method to verify if a given symbol is found 3 times in a     * single row. If we have 3 matches, it will return TRUE. In all other     * cases it will return FALSE.     *      * @param string $symbol     * @return boolean     */    public function inRow($symbol)    {        foreach ($this->getRows() as $row) {            $match = 0;            foreach ($row as $column) {                if ($symbol === $column) {                    $match++;                }            }            if (self::ROWS === $match) {                return true;            }        }        return false;    }    /**     * Validation method to verify if a given symbol is found 3 times in a     * single column. If we have 3 matches, it will return TRUE. In all other     * cases it will return FALSE.     *      * @param string $symbol     * @return boolean     */    public function inColumn($symbol)    {        for ($i = 0; $i < self::COLS; $i++) {            $match = 0;            for ($j = 0; $j < self::ROWS; $j++) {                if ($symbol === $this->_rows[$j][$i]) {                    $match++;                }            }            if (self::COLS === $match) {                return true;            }        }        return false;    }    /**     * Validation method to verify if a given symbol is found 3 times in a     * single diagonal row. If we have 3 matches, it will return TRUE. In all      * other cases it will return FALSE.     *      * @param string $symbol     * @return boolean     */    public function inDiagonal($symbol)    {        $match1 = $match2 = 0;        for ($i = 0; $i < self::ROWS; $i++) {            if ($symbol === $this->_rows[$i][$i]) {                $match1++;            }            if ($symbol === $this->_rows[$i][self::COLS - 1 - $i]) {                $match2++;            }        }        if (self::ROWS === $match1 || self::ROWS === $match2) {            return true;        }        return false;    }}    

Now we have a grid class, but we cannot test it properly as we use a Tictactoe class to validate everything. No problem, we can modify our tests as well to better serve our needs. Actually, we already have defined our test criteria. Let’s list them again:

  • Grid is part of our main TicTacToe class (is not really relevant for our Grid functionality)
  • has a method that fetches rows of type array
    • and each row has columns as an array
  • Grid class will instantiate a grid with 3 rows and 3 columns
  • When calling “getRows()” we retrieve an array of 3 rows with each 3 columns
  • Each field in the grid will have a null value as a default
  • A Player must have a way to set his “symbol” on a specific position on the grid
  • Must have a way to verify if a given symbol exists in either a horizontal, a vertical or a diagonal row

The first four criterea we already addressed in our general Tictactoe test case. To separate responsibilities, we can move our test case from our main TictactoeTest class into a GridTest class.

<?phpclass GridTest extends PHPUnit_Framework_TestCase{    const TEST_SYMBOL = 'X';

    protected $_grid;

    protected function setUp()    {        $this->_grid = new Grid();        parent::setUp();    }    protected function tearDown()    {        parent::tearDown();        $this->_grid = null;    }    public function testGameGridIsSetAtStart()    {        $this->assertEquals(Grid::ROWS, count($this->_grid->getRows()));        foreach ($this->_grid->getRows() as $row) {            $this->assertInternalType('array', $row);            $this->assertEquals(Grid::COLS, count($row));            foreach ($row as $column) {                $this->assertNull($column);            }        }    }}

So now we have exactly the same as before, except we created a separate TestCase specifically designed for Grid related tests. This allows us to follow up on issues people might report later on (things we haven’t thought of or just don’t know yet), as we can write now a specific test for our Grid.

But we’re not there yet, we still have 2 more things to verify: positioning of a symbol and verifying we have a 3 identical symbols in any of the three rows, columns or diagonal rows.

Let’s look at our test verifying the positioning of a symbol:

    public function testGridCanPositionASymbol()    {        $this->_grid->setSymbol(0, 0, self::TEST_SYMBOL);        $this->assertNotNull($this->_grid->getSymbol(0,0));        $this->assertEquals(self::TEST_SYMBOL, $this->_grid->getSymbol(0,0));    }

But as you see, this is not really working for us. We can only ferify just one position on the grid and if we want to test more positions, our test method would grow exponentionally. Say hello to the “dataProvider”

    public function cordinateProvider()    {        return array (            array (0,0), array (0,1), array (0,2), array (1,0), array (1,1),            array (1,2), array (2,0), array (2,1), array (2,2),        );    }    /**     * @dataProvider cordinateProvider     */    public function testGridCanPositionASymbol($row, $column)    {        $this->_grid->setSymbol($row, $column, self::TEST_SYMBOL);        $this->assertNotNull($this->_grid->getSymbol($row, $column));        $this->assertEquals(self::TEST_SYMBOL, $this->_grid->getSymbol($row, $column));    }

The @dataProvider tag in your codeblock comment tells PHPUnit to use the method specified by this tag as a “provider” of data. Each row in this data provider method (as it returns an array of arrays) will be a provisioner for your test class, and for each row, your test will be executed from a clean state, so you don’t have any corruption due to bad resetting of your objects.

Hey, now we can also use this to verify if we have 3 identical symbols in a horizontal, vertical or diagonal row! Let’s work that out as well.

    protected function _setDataOnGrid($data)    {        foreach ($data as $field) {            list ($row, $column) = $field;            $this->_grid->setSymbol($row, $column, self::TEST_SYMBOL);        }    }    public function horizontalRowProvider()    {        return array (            array (array (array (0,0), array (0,1), array (0,2))),            array (array (array (1,0), array (1,1), array (1,2))),            array (array (array (2,0), array (2,1), array (2,2))),        );    }    /**     * @dataProvider horizontalRowProvider     */    public function testGridHasThreeSymbolsInARow($data)    {        $this->_setDataOnGrid($data);        $this->assertTrue($this->_grid->inRow(self::TEST_SYMBOL));    }    public function VerticalRowProvider()    {        return array (            array (array (array (0,0), array (1,0), array (2,0))),            array (array (array (0,1), array (1,1), array (2,1))),            array (array (array (0,2), array (1,2), array (2,2))),        );    }    /**     * @dataProvider VerticalRowProvider     */    public function testGridHasThreeSymbolsInAColumn($data)    {        $this->_setDataOnGrid($data);        $this->assertTrue($this->_grid->inColumn(self::TEST_SYMBOL));    }    public function DiagonalRowProvider()    {        return array (            array (array (array (0,0), array (1,1), array (2,2))),            array (array (array (0,2), array (1,1), array (2,0))),        );    }    /**     * @dataProvider DiagonalRowProvider     */    public function testGridHasThreeSymbolsInADiagonal($data)    {        $this->_setDataOnGrid($data);        $this->assertTrue($this->_grid->inDiagonal(self::TEST_SYMBOL));    }

Oh, Wow! We now have a complete Grid test case that isolates all Grid related tasks and responsibilities.

<?phpclass GridTest extends PHPUnit_Framework_TestCase{    const TEST_SYMBOL = 'X';

    protected $_grid;

    protected function setUp()    {        $this->_grid = new Grid();        parent::setUp();    }    protected function tearDown()    {        parent::tearDown();        $this->_grid = null;    }    public function testGameGridIsSetAtStart()    {        $this->assertEquals(Grid::ROWS, count($this->_grid->getRows()));        foreach ($this->_grid->getRows() as $row) {            $this->assertInternalType('array', $row);            $this->assertEquals(Grid::COLS, count($row));            foreach ($row as $column) {                $this->assertNull($column);            }        }    }    public function cordinateProvider()    {        return array (            array (0,0), array (0,1), array (0,2), array (1,0), array (1,1),            array (1,2), array (2,0), array (2,1), array (2,2),        );    }    /**     * @dataProvider cordinateProvider     */    public function testGridCanPositionASymbol($row, $column)    {        $this->_grid->setSymbol($row, $column, self::TEST_SYMBOL);        $this->assertNotNull($this->_grid->getSymbol($row, $column));        $this->assertEquals(self::TEST_SYMBOL, $this->_grid->getSymbol($row, $column));    }    protected function _setDataOnGrid($data)    {        foreach ($data as $field) {            list ($row, $column) = $field;            $this->_grid->setSymbol($row, $column, self::TEST_SYMBOL);        }    }    public function horizontalRowProvider()    {        return array (            array (array (array (0,0), array (0,1), array (0,2))),            array (array (array (1,0), array (1,1), array (1,2))),            array (array (array (2,0), array (2,1), array (2,2))),        );    }    /**     * @dataProvider horizontalRowProvider     */    public function testGridHasThreeSymbolsInARow($data)    {        $this->_setDataOnGrid($data);        $this->assertTrue($this->_grid->inRow(self::TEST_SYMBOL));    }    public function VerticalRowProvider()    {        return array (            array (array (array (0,0), array (1,0), array (2,0))),            array (array (array (0,1), array (1,1), array (2,1))),            array (array (array (0,2), array (1,2), array (2,2))),        );    }    /**     * @dataProvider VerticalRowProvider     */    public function testGridHasThreeSymbolsInAColumn($data)    {        $this->_setDataOnGrid($data);        $this->assertTrue($this->_grid->inColumn(self::TEST_SYMBOL));    }    public function DiagonalRowProvider()    {        return array (            array (array (array (0,0), array (1,1), array (2,2))),            array (array (array (0,2), array (1,1), array (2,0))),        );    }    /**     * @dataProvider DiagonalRowProvider     */    public function testGridHasThreeSymbolsInADiagonal($data)    {        $this->_setDataOnGrid($data);        $this->assertTrue($this->_grid->inDiagonal(self::TEST_SYMBOL));    }}

Running this test along with our initial TictactoeTest should result in a warm, fuzzy, green feeling when you see this screen:

Next time, let’s look at our Players as the need also some respect, right.



Author:

by News Robot on August 23, 2011 in News, No Comments »
tags: , , , ,

Quality Assurance on PHP projects – PHPUnit part 1

Of all tools available for improving quality assurance, there’s one tool that is the core tool you have to master: PHPUnit. PHPUnit is a complete testing framework crafted by Sebastian Bergmann (@s_bergmann), who ported existing xUnit frameworks to PHP. And with this testing framework you’re able to test your functionality in an automated way before you push code into production.

[editorial] As I cannot summarize the whole usage of phpunit in one blogpost, this will be a sequence of several articles that will pick up a specific task you want to cover with phpunit.

Installation
Well, first of all you need to have PHPUnit installed on your system. The easiest way to accomplish this is to use the PEAR installer.

user@server: $ pear channel-discover pear.phpunit.de
user@server: $ pear channel-discover components.ez.no
user@server: $ pear channel-discover pear.symfony-project.com

Once you’ve got the right channels, you can install the framework:

user@server: $ pear install phpunit/PHPUnit

Configuration
You can use three methods to configure the way PHPUnit executes tests on your project:
  • a configuration file
  • command line parameters
  • a combination of both

Using a configuration file called “phpunit.xml” is by far the easiest way to run your unit tests in a consistent and organized way. It’s a simple XML configuration file and the following works for me most of the times.


NOTE: I use phpunit with a configuration file that matches my project settings, so you might need to modify these settings if you’re using a framework or have a different source code layout.

<phpunit bootstrap=”./TestHelper.php” colors=”true”>
    <testsuite name=”Unit test suite”>
        <directory>./</directory>
    </testsuite>

    <filter>
        <whitelist>
            <directory suffix=”.php”>../src/</directory>
        </whitelist>
    </filter>
</phpunit>

This simple configuration file has 3 major parts:

1. The phpunit configuration tag
This tag starts the complete configuration, but also includes a bootstrap file (for bootstrapping your application like Zend Framework’s bootstrapper class) and enables colors to show green, yellow and red colored bars to indicate the status of your tests. Since I’m a fan of a warm, fuzzy feeling whenever I see green, I enable this by default.

2. Testsuite section
The testsuite is a wrapper that bundles all your tests into a single suite, so you can call it immediately at execution. You can provide it with a name and a directory.
This section is very useful if you have multiple sections in your projects that you want to separate, as you can define the test suites based on their paths on the filesystem.

3. Filtering
Filtering allows you to quickly define what needs to be tested and what needs to be excluded. In my case I need just to investigate my Zend Framework application path and my custom library path. I also want to exclude all my templates as they don’t contain any logic.

You can add also a section for logging where you can define code coverage reports (requires XDebug), a testdox progress report and other kinds of reports provided by PHPUnit. But since I will transfer these tasks to another tool, I’m not going to discuss it here.

I also use a bootstrap file for phpunit called TestHelper.php that allows me to “bootstrap” my test suite. This bootstrap file sets my defined constants, include paths, timezone and error reporting levels.

This is a very minimalistic bootstrapper:
<?php
// file: tests/TestHelper.php

// set our app paths and environments
define(‘BASE_PATH’, realpath(dirname(__FILE__) . ‘/../’));
define(‘APPLICATION_PATH’, BASE_PATH . ‘/src’);
define(‘TEST_PATH’, BASE_PATH . ‘/tests’);
define(‘APPLICATION_ENV’, ‘testing’);

// Include path
set_include_path(
    ‘.’
    . PATH_SEPARATOR . BASE_PATH . ‘/src’
    . PATH_SEPARATOR . get_include_path()
);

// Set the default timezone !!!
date_default_timezone_set(‘Europe/Brussels’);

// We wanna catch all errors en strict warnings
error_reporting(E_ALL|E_STRICT);

So how do you start?
Testing is really simple but for most people the complexity of having code testing other code and just report back if it’s working or not is a bit confusing for people that haven’t written any tests before.

For the most part, in my professional career I get a lot of excuses like “no time”, “no budget” or “no interest”. If it’s truly such a big problem to cope with something as simple as writing a test, a career change might be in order. And I mean it. I believe that if you’re serious about your job, you have to take a little responsibility in it. And writing tests is not that hard.

Let’s begin with a classic example: a tic-tac-toe game. This is a simple pen-and-paper game for two players (O and X) that uses a grid of 3 by 3. The purpose of the game is to have a row, a column or a diagonal row filled with only O’s or X’s. More information can be found at http://en.wikipedia.org/wiki/Tic-tac-toe.

source: http://en.wikipedia.org/wiki/File:Tic-tac-toe-game-1.png

So how do you start with this kind of a game? Very simple: define the objects, the rules and the goal of this game in a list that makes sense to you. I like to define it as follows:
  • objects:
    • symbol X for user 1
    • symbol Y for user 2
    • play grid of 3 rows by 3 columns
  • rules:
    • write your symbol once for each turn within the grid
  • goal:
    • prevent opponent to win
    • win by having 3 symbols on a single row, a single column or a single diagonal row

Since I have tendency to write my tests before I write the code, as it allows me to think about what I expect I should get from class methods. Another benefit is that you write smaller classes with methods that just do what needs to be done.


TictactoeTest
Let’s define our general outline for our main class Tictactoe. We already know a few things: two players, a grid of 3 rows by 3 columns and a winner when three identical symbols are in a single row horizontal, vertical or diagonal.

In test code it would look something like this:
<?php
// file: tests/TictactoeTest.php
require_once ‘Tictactoe.php’;
class TictactoeTest extends PHPUnit_Framework_TestCase
{
    public function testGameGridIsSetAtStart()
    {
        // test to see a grid is created of 3 by 3 and all fields are null
    }
    public function testGamePlayersAreSetAtStart()
    {
        // test to see players are set up at start with symbols X and O
    }
    public function testGameCanBePlayed()
    {
        // play a simple game with two players turn by turn
        // returning true or false would notify us if there’s a winner or not
    }
}

We test 3 major things here: that a grid is set, that two players are created and that the game can be played. We don’t worry for edge cases or exceptions now, as we can take care of that later.

When we run this test, we get a bunch of errors, basically saying that we don’t have a Tictactoe class file yet. At this point, this is very normal.

user@server:/dev/ttt/tests $ phpunit
PHP Warning:  require_once(Tictactoe.php): failed to open stream: No such file or directory in /dev/ttt/tests/TictactoeTest.php on line 3

Warning: require_once(Tictactoe.php): failed to open stream: No such file or directory in /dev/ttt/tests/TictactoeTest.php on line 3
PHP Fatal error:  require_once(): Failed opening required ‘Tictactoe.php’ (include_path=’.:/dev/ttt/src:.:/usr/lib/php/pear’) in /dev/ttt/tests/TictactoeTest.php on line 3

Fatal error: require_once(): Failed opening required ‘Tictactoe.php’ (include_path=’.:/dev/ttt/src:.:/usr/lib/php/pear’) in /dev/ttt/tests/TictactoeTest.php on line 3

We’ve got are main goals set, now it’s time to make some assertions to see we get the information we want.

First of all, we’re going to setUp and tearDown our test case, so we know each test starts with a clean slate.

class TictactoeTest extends PHPUnit_Framework_TestCase
{
    protected $_ttt;

    protected function setUp()
    {
        parent::setUp();
        $this->_ttt = new Tictactoe();
    }
    protected function tearDown()
    {
        $this->_ttt = null;
        parent::tearDown();
    }

Now we need to fill in the blanks regarding the test methods. Let’s start with our first method: 

    public function testGameGridIsSetAtStart()
    {
        // we should be able to retrieve the grid from our Tictactoe class
        $grid = $this->_ttt->getGrid();

        // let’s make sure we created a grid class to handle all grid related manipulations
        $this->assertInstanceOf(‘Grid’, $grid);

        // we know the grid is 3 x 3, so let’s count the rows
        $this->assertEquals(3, count($grid->getRows()));

        // and for each row, let’s count the columns
        // and since we’re at it, let’s check that their fields are empty
        foreach ($grid->getRows() as $row) {
            $this->assertInternalType(‘array’, $row);
            $this->assertEquals(3, count($row));
            foreach ($row as $column) {
                $this->assertNull($column);
            }
        }
    }

So, what do we learn from this test? We need to have a Grid class to take care of all grid related things and we need to ensure each field is empty before we start playing. Take a note of this as we need it later!

The next step is to set up our players. We know we have two players and each player has his own symbol (X or O).

    public function testGamePlayersAreSetAtStart()
    {
        // we should be able to retrieve all players from our Tictactoe class
        $players = $this->_ttt->getPlayers();

        // ensure that players have their own class to take care of all players
        $this->assertInstanceOf(‘Players’, $players);

        // we know we only have two players
        $this->assertEquals(2, count($players));

        // we want to ensure that each player has the correct symbol
        $this->assertEquals(Player::PLAYER_X, $players->seek(0)->current()->getSymbol());
        $this->assertEquals(Player::PLAYER_O, $players->seek(1)->current()->getSymbol());
    }

This test teaches us we need another two classes for our players. One class is acting as a collection implementing the SeekableIterator and Countable interfaces from SPL (I just love these, so I know I will use them!). The second class defines the player and the symbol it gets.

Our last test method is all about playing the game.

    public function testGameCanBePlayed()
    {
        // let’s pick just one player
        $player = $this->_ttt->getPlayers()->seek(0)->current();

        // and see if we can win if we created a row
        $this->assertFalse($this->_ttt->play(0, 0, $player));
        $this->assertFalse($this->_ttt->play(0, 1, $player));
        $this->assertTrue($this->_ttt->play(0, 2, $player));

        // and see if we can win if we created a column
        $this->assertFalse($this->_ttt->play(0, 1, $player));
        $this->assertFalse($this->_ttt->play(1, 1, $player));
        $this->assertTrue($this->_ttt->play(2, 1, $player));

        // and see if we can win if we go diagonal left to right
        $this->assertFalse($this->_ttt->play(0, 0, $player));
        $this->assertFalse($this->_ttt->play(1, 1, $player));
        $this->assertTrue($this->_ttt->play(2, 2, $player));

        // and see if we can win if we go diagonal right to left
        $this->assertFalse($this->_ttt->play(0, 0, $player));
        $this->assertFalse($this->_ttt->play(1, 1, $player));
        $this->assertTrue($this->_ttt->play(2, 2, $player));
    }

In my next article we’re going to set up our classes that should turn this test into a success. In the mean time, I challenge you to figure out how the code might look like. And if you want, share that code with everyone by posting it on pastebin.com, pastie.org or using github’s gist.




Author:

by News Robot on August 17, 2011 in News, No Comments »
tags: , , , ,